Fix angle and rotation bugs in math utils #2755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s argument order, fixed rotate_around_point offset, converted degrees to radians in rand_vec_spread_deg
DragonMoffon
requested changes
Oct 15, 2025
There was a problem hiding this comment.
rand_vec_magnitude should also convert to radians, as arcade operates almost wholly on degrees, so this function expecting radians breaks convention
Also, it would be good to add unit tests for all of these functions. Preferably a unit test for every function in arcade.math, but that's out of the scope of this PR.
Having checked the arcade.math tests they are sorely lacking and can be fixed in a later PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed three bugs in math.py:
rand_vec_spread_degto convert degrees to radians before passing toVec2.from_polar. Bug: rand_vec_spread_deg incorrectly passes degrees to Vec2.from_polar which requires radians #2648rotate_around_pointto properly rotate around thesourcepoint instead of thetarget. Bug: rotate_around_point function in math.py returns incorrect results due to wrong translation #2753math.atan2inget_angle_radiansfunction, which previously caused incorrect angle calculations. Bug: get_angle_radians function in math.py returns incorrect angle due to swapped atan2 parameters #2754