Add a parameter create to resolve() to create the directory/file if it doesn't exist.
#2751
+61
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackAshwell11
force-pushed
the
resolve_create
branch
2 times, most recently
from
969fc71 to
a86233f
Compare
…if it doesn't exist.
JackAshwell11
force-pushed
the
resolve_create
branch
from
a86233f to
fda2e06
Compare
DragonMoffon
requested changes
Oct 15, 2025
There was a problem hiding this comment.
Looks good otherwise.
Since this PR modifies this code already, could we add an additional check. importlib.resources.Traversable is also a common type passed into this method, and it doesn't have a consistent interface with pathlib.Path. See the docs.
We should either have the function work perfectly with either a Path or Traversable or check for and change a Traversable to a Path
| Create a file or directory at the given path. | ||
| If the path has a suffix, it's treated as a file, otherwise, as a directory. | ||
| """ | ||
| if path.suffix: |
There was a problem hiding this comment.
Path objects have an is_dir method, which is probably a safer check.
Comment on lines
+124
to
+125
| if create: | ||
| create_path(path) |
There was a problem hiding this comment.
Should this not also check if the path exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.