Skip to content

Allow urlparse and urlsplit of bytes URLs #9746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Allow urlparse and urlsplit of bytes URLs #9746

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bab464
add default value to bytes overload of urlsplit and urlparse
koogoro Feb 17, 2023
71a2d85
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 17, 2023
670a7b2
merge second and third overloads
koogoro Feb 17, 2023
b8dccd6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions stdlib/urllib/parse.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,9 @@ def urljoin(base: AnyStr, url: AnyStr | None, allow_fragments: bool = True) -> A
@overload
def urlparse(url: str, scheme: str = "", allow_fragments: bool = True) -> ParseResult: ...
@overload
def urlparse(url: bytes | bytearray, scheme: bytes | bytearray | None, allow_fragments: bool = True) -> ParseResultBytes: ...
def urlparse(
url: bytes | bytearray, scheme: bytes | bytearray | None | Literal[""] = "", allow_fragments: bool = True
) -> ParseResultBytes: ...
@overload
def urlparse(
url: None, scheme: bytes | bytearray | None | Literal[""] = "", allow_fragments: bool = True
Expand All @@ -202,13 +204,15 @@ def urlsplit(url: str, scheme: str = "", allow_fragments: bool = True) -> SplitR

if sys.version_info >= (3, 11):
@overload
def urlsplit(url: bytes, scheme: bytes | None, allow_fragments: bool = True) -> SplitResultBytes: ...
def urlsplit(url: bytes, scheme: bytes | None | Literal[""] = "", allow_fragments: bool = True) -> SplitResultBytes: ...
@overload
def urlsplit(url: None, scheme: bytes | None | Literal[""] = "", allow_fragments: bool = True) -> SplitResultBytes: ...

else:
@overload
def urlsplit(url: bytes | bytearray, scheme: bytes | bytearray | None, allow_fragments: bool = True) -> SplitResultBytes: ...
def urlsplit(
url: bytes | bytearray, scheme: bytes | bytearray | None | Literal[""] = "", allow_fragments: bool = True
) -> SplitResultBytes: ...
@overload
def urlsplit(
url: None, scheme: bytes | bytearray | None | Literal[""] = "", allow_fragments: bool = True
Expand Down