Skip to content

[django-filter] Replace list with more generic Sequence #14567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

[django-filter] Replace list with more generic Sequence #14567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09890ef
Replace list with more generic Collection
H4rryK4ne Aug 12, 2025
5d52b74
Replace Collection by Sequence
H4rryK4ne Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions stubs/django-filter/django_filters/filterset.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from collections import OrderedDict
from collections.abc import Sequence
from enum import Enum
from typing import Any, ClassVar

Expand All @@ -18,8 +19,8 @@ class UnknownFieldBehavior(Enum):

class FilterSetOptions:
model: type[Model] | None
fields: list[str] | dict[str, list[str]] | str | None
exclude: list[str] | None
fields: Sequence[str] | dict[str, Sequence[str]] | str | None
exclude: Sequence[str] | None
filter_overrides: dict[type[models.Field[Any, Any]], dict[str, Any]] # Field override mapping
form: type[Form]
unknown_field_behavior: UnknownFieldBehavior
Expand Down Expand Up @@ -81,5 +82,5 @@ class BaseFilterSet:
class FilterSet(BaseFilterSet, metaclass=FilterSetMetaclass): ...

def filterset_factory(
model: type[Model], filterset: FilterSetMetaclass = ..., fields: list[str] | dict[str, list[str]] | str | None = None
model: type[Model], filterset: FilterSetMetaclass = ..., fields: Sequence[str] | dict[str, Sequence[str]] | str | None = None
) -> type[FilterSet]: ...
Loading