Update jsonschema.protocols.Validator.__init__
#14327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of this protocol has changed in recent versions of `jsonschema`. Update to match.
|
Diff from mypy_primer, showing the effect of this PR on open source code: check-jsonschema (https://github.com/python-jsonschema/check-jsonschema)
- src/check_jsonschema/schema_loader/main.py:190: error: Unexpected keyword argument "registry" for "Validator" [call-arg]
+ src/check_jsonschema/schema_loader/main.py:219: error: Missing positional argument "registry" in call to "Validator" [call-arg]
+ src/check_jsonschema/schema_loader/main.py:277: error: Missing positional argument "registry" in call to "Validator" [call-arg]
schemathesis (https://github.com/schemathesis/schemathesis)
+ src/schemathesis/specs/openapi/definitions.py: note: In function "make_validator":
+ src/schemathesis/specs/openapi/definitions.py:1918: error: Missing positional argument "registry" in call to "Validator" [call-arg]
+ src/schemathesis/specs/openapi/negative/__init__.py: note: In function "get_validator":
+ src/schemathesis/specs/openapi/negative/__init__.py:43: error: Missing positional argument "registry" in call to "Validator" [call-arg]
+ src/schemathesis/specs/openapi/negative/__init__.py: note: At top level:
|
|
☝️ Quick note on the above This is just what we get with a verbatim copy of the |
sirosen
added a commit
to sirosen/typeshed
that referenced
this pull request
Aug 19, 2025
In python-jsonschema/jsonschema#1396 , the type signature for `Validator.__init__` is updated to better match the runtime signature. This backports the fix to typeshed, keeping the copies of this data in sync. python-jsonschema/jsonschema#1396 is, itself, a response to feedback on `jsonschema` about the changes in `typeshed` python#14327. In addition to the `__init__` fix, a couple of additional small changes are made, both in `jsonschema` and here in the stubs: 1. In `jsonschema`, the type for `create()` in `validators.py` was updated to be notated with `-> type[Validator]`. This was necessary for internal testing on types to correctly read that validator classes created by this factory implement the protocol. 2. Here, in order to better guarantee that the types align, the `_Validator` class (which does not exist in `jsonschema`, but is only defined here in the stubs) now inherits from `Validator`. 3. The init signature for `_Validator` is updated to match 4. `tests/mypy_test.py` flags the `schema` instance variable annotation as mismatching between `Validator` and `_Validator`. Review against the `jsonschema` source reveals that `_Validator` was closer to correct, so `Validator` is fixed to match. Any further changes (e.g., elimination of `_Validator` or changing `create`'s return type annotation) are left as potential future work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of this protocol has changed in recent versions of
jsonschema. Update to match.Aside: There was a period (~1 year ago?) when I was actively working on
jsonschematypes with a plan to backport things from typeshed tojsonschema.I got a bit bogged down and the work is unfinished, but I would ultimately like to help make that happen. In the meantime, I still want to keep these in sync. :)