[mypyc] Fix remaining failing test on free-threaded builds #19646
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just skip an in irbuild test if running on a free-threaded build, since the IR looks different if free threading is enabled.
ilevkivskyi
approved these changes
Aug 12, 2025
| @@ -71,6 +71,9 @@ def run_case(self, testcase: DataDrivenTestCase) -> None: | |||
| if options is None: | |||
| # Skipped test case | |||
| return | |||
| if "_withgil" in testcase.name and IS_FREE_THREADED: | |||
There was a problem hiding this comment.
Btw, as an option, you can add an opposite marker _withnogil, and have two copies of the problematic test with both markers and the different outputs for each marker (I remember we had something similar for daemon, where the order of error messages depends on whether we use cache or not).
There was a problem hiding this comment.
Yeah, that's a good idea. In this case the free threading variant doesn't seem super useful, and a better way to test for the free threading behavior would be to have multi-threaded perf scaling benchmarks. But in the future it seems likely that we'll want separate no-GIL irbuild test cases, and we can implement your idea then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just skip an in irbuild test if running on a free-threaded build, since the IR looks different if free threading is enabled.
Only this one test was failing for me on Python 3.14.0rc1.