Skip to content

Add support for rendering a local copy of resources on the file system #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2022
Merged

Add support for rendering a local copy of resources on the file system #255

merged 8 commits into from
Jul 22, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jul 3, 2022 •
edited
Loading

Fixes #228

  • Add _common._as_tree to demonstrate a directory of resources.
  • Remove type hints as they're causing trouble.
  • Allow as_file to return a context manager for a directory or a file as needed.
  • Rewrite _temp_dir so that it produces a directory of the same name as the input path.

@jaraco jaraco marked this pull request as draft July 3, 2022 19:32
@jaraco jaraco marked this pull request as ready for review July 3, 2022 23:12
jaraco
jaraco commented Jul 22, 2022
View reviewed changes
@jaraco jaraco merged commit 3110294 into main Jul 22, 2022
@jaraco jaraco deleted the feature/228-directory-of-resources branch July 22, 2022 16:37
@jaraco
Copy link
Member Author

jaraco commented Oct 5, 2022

Released in v5.9.0.

@jaraco jaraco mentioned this pull request Oct 5, 2022
Closed
@lorengordon lorengordon mentioned this pull request Jan 29, 2023
Open
freyes added a commit to openstack-charmers/charmed-openstack-info that referenced this pull request Feb 3, 2023
@freyes
Bump up importlib-resource dependency
d4098a6 
Due to bug python/importlib_resources#255
@jaraco jaraco mentioned this pull request Mar 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for a directory of resources
1 participant
@jaraco