Skip to content

gh-93955: Use unbound methods for slot __getattr__ and __getattribute__ #93956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2022
Merged

gh-93955: Use unbound methods for slot __getattr__ and __getattribute__ #93956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91fa05e
Use unbound methods for slot `__getattr__`
Fidget-Spinner Jun 17, 2022
4c28ac6
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 17, 2022
c2b7441
fix refleak
Fidget-Spinner Jun 17, 2022
59139a1
Merge branch 'unbound_method_call_attribute' of https://github.com/Fi…
Fidget-Spinner Jun 17, 2022
83809ba
Remove call_attribute
Fidget-Spinner Jun 17, 2022
c83149d
re-add speed hacks
Fidget-Spinner Jun 17, 2022
0e14cc7
fix comment
Fidget-Spinner Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-06-17-16-30-24.gh-issue-93955.LmiAe9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve performance of attribute lookups on objects with custom ``__getattribute__`` and ``__getattr__``. Patch by Ken Jin.
9 changes: 8 additions & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7782,10 +7782,17 @@ slot_tp_getattro(PyObject *self, PyObject *name)
return vectorcall_method(&_Py_ID(__getattribute__), stack, 2);
}

static PyObject *
static inline PyObject *
call_attribute(PyObject *self, PyObject *attr, PyObject *name)
{
PyObject *res, *descr = NULL;

if (_PyType_HasFeature(Py_TYPE(attr), Py_TPFLAGS_METHOD_DESCRIPTOR)) {
PyObject *args[] = { self, name };
res = PyObject_Vectorcall(attr, args, 2, NULL);
return res;
}

descrgetfunc f = Py_TYPE(attr)->tp_descr_get;

if (f != NULL) {
Expand Down