Skip to content

gh-91877: Fix "Write Transports" table in asyncio docs #92338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2022
Merged

gh-91877: Fix "Write Transports" table in asyncio docs #92338

merged 1 commit into from
Jun 14, 2022

Conversation

TechieBoy
Copy link
Contributor

Fixes gh-91877

@TechieBoy TechieBoy requested review from 1st1 and asvetlov as code owners May 5, 2022 15:02
@ghost
Copy link

ghost commented May 5, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 5, 2022
carljm
carljm approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks correct.

@erlend-aasland
Copy link
Contributor

Kumar, should this be backported? I don't know the asyncio module.

@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 14, 2022
@kumaraditya303
Copy link
Contributor

Kumar, should this be backported? I don't know the asyncio module.

Yes, it should be backported, I applied the labels.

@erlend-aasland erlend-aasland changed the title gh-91877 Fix "Write Transports" table in asyncio docs gh-91877: Fix "Write Transports" table in asyncio docs Jun 14, 2022
@kumaraditya303
Copy link
Contributor

@erlend-aasland: You can merge this :)

@erlend-aasland erlend-aasland merged commit a338e10 into python:main Jun 14, 2022
@miss-islington
Copy link
Contributor

Thanks @TechieBoy for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland
Copy link
Contributor

Argh, I mixed up the two attrs in the commit message 😦

@erlend-aasland
Copy link
Contributor

Would you mind creating the backport PR's, Kumar? I'm afraid Miss Islington is having a bad day.

@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 14, 2022
@miss-islington
Copy link
Contributor

Thanks @TechieBoy for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @TechieBoy for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@kumaraditya303
Copy link
Contributor

Would you mind creating the backport PR's, Kumar? I'm afraid Miss Islington is having a bad day.

Yes, I'll create it.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 14, 2022
@bedevere-bot
Copy link

GH-93806 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 14, 2022
@bedevere-bot
Copy link

GH-93805 is a backport of this pull request to the 3.10 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid method name in asyncio low-level API index
7 participants
@TechieBoy @bedevere-bot @erlend-aasland @kumaraditya303 @miss-islington @carljm @AlexWaygood