Skip to content

bpo-32204: Optimize asyncio.Future _schedule_callbacks #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-32204: Optimize asyncio.Future _schedule_callbacks #4186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/asyncio/futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,14 @@ def _schedule_callbacks(self):
The callbacks are scheduled to be called as soon as possible. Also
clears the callback list.
"""
callbacks = self._callbacks[:]
if not callbacks:
if not self._callbacks:
return

self._callbacks[:] = []
for callback in callbacks:
for callback in self._callbacks:
self._loop.call_soon(callback, self)

self._callbacks.clear()

def cancelled(self):
"""Return True if the future was cancelled."""
return self._state == _CANCELLED
Expand Down