Skip to content

[backport to 2.7] bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[backport to 2.7] bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations #382

wants to merge 2 commits into from

Conversation

mjpieters
Copy link
Contributor

Backport of #51

@zhangyangyu
Copy link
Member

Ohh, I have done it in #366 .

@berkerpeksag
Copy link
Member

Thanks, @mjpieters! This is already done in #366.

@mjpieters
Copy link
Contributor Author

😃 I realised when I saw the conflict, and was scouring my overflowing inbox for the ticket correspondence. Thanks for doing this, @zhangyangyu!

@mjpieters mjpieters deleted the bpo28598_backport_2.7 branch March 1, 2017 16:55
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Fix Automerge functionality (#382)
dc67f1e 
* Fix Automerge functionality

Look up conclusions from check runs in addition to status checks.

Ensure all check runs have completed.
Ensure there is no "failure" or "timed_out" result from the check runs

Fixes python/miss-islington#375

* 🐍🌚🤖 Formatted using `black`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjpieters @zhangyangyu @berkerpeksag @the-knights-who-say-ni