Skip to content

[doc] Fix typo #26991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2021
Merged

[doc] Fix typo #26991

merged 1 commit into from
Jul 3, 2021

Conversation

@srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jul 2, 2021

No description provided.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jul 2, 2021
nanjekyejoannah
nanjekyejoannah reviewed Jul 2, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, can you check why CI is failing?

@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Jul 2, 2021

I do not know why it is failing. Looks very similar to #26990. Maybe @iritkatriel can shed some light on this?

@iritkatriel iritkatriel changed the title NO-TICKET: fix a small typo in the docs [doc] Fix typo Jul 2, 2021
@iritkatriel
Copy link
Member

iritkatriel commented Jul 2, 2021

The CI failure is unrelated. Does this need backporting to 3.10 and 3.9?

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Jul 2, 2021 •
edited
Loading

I fixed the news item causing the CI to fail at #26994. Please take a look if y'all have the time.

Once that's merged, you can update this branch from main again which will let the CI pass.

@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah commented Jul 2, 2021 •
edited
Loading

The CI failure is unrelated. Does this need backporting to 3.10 and 3.9?

I am inclined to say so

@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Jul 3, 2021

@nanjekyejoannah The build is passing now. I think we should merge this PR and backport it to 3.9 and 3.10

@nanjekyejoannah nanjekyejoannah merged commit a79e2b6 into python:main Jul 3, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jul 3, 2021

Thanks @srinivasreddy for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 3, 2021

Sorry, @srinivasreddy and @nanjekyejoannah, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a79e2b6497f7d31017c01a41a290a9b3349398fe 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2021
@srinivasreddy @miss-islington
Fix a small typo in the docs (pythonGH-26991)
99a1d87 
(cherry picked from commit a79e2b6)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 3, 2021
@bedevere-bot
Copy link

bedevere-bot commented Jul 3, 2021

GH-27003 is a backport of this pull request to the 3.10 branch.

nanjekyejoannah
nanjekyejoannah reviewed Jul 3, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @srinivasreddy for the fix!

nanjekyejoannah pushed a commit that referenced this pull request Jul 3, 2021
@miss-islington @srinivasreddy
Fix a small typo in the docs (GH-26991) (GH-27003)
bea618d 
(cherry picked from commit a79e2b6)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

Assignees

@nanjekyejoannah nanjekyejoannah

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@srinivasreddy @iritkatriel @Fidget-Spinner @nanjekyejoannah @miss-islington @bedevere-bot @the-knights-who-say-ni @ZeroIntensity