Skip to content

bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState #17287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState #17287

merged 1 commit into from
Nov 20, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 20, 2019 •
edited by bedevere-bot
Loading

  • Rename _PyGC_InitializeRuntime() to _PyGC_InitState()
  • finalize_interp_clear() now also calls _PyGC_Fini() in
    subinterpreters.

https://bugs.python.org/issue36854

@vstinner
bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState
113b626 
* Rename _PyGC_InitializeRuntime() to _PyGC_InitState()
* finalize_interp_clear() now also calls _PyGC_Fini() in
  subinterpreters.
@vstinner vstinner requested a review from pablogsal as a code owner November 20, 2019 11:03
@vstinner
Copy link
Member Author

cc @ericsnowcurrently @pablogsal @nanjekyejoannah: That's a great achievement/milestone for the implementation of subinterpreters ;-)

Eric: I managed to reorganize Python thread state finalization to prevent having to call tstate->on_delete() earlier (you called it in PyThreadState_Clear()).

@vstinner vstinner merged commit 7247407 into python:master Nov 20, 2019
@vstinner vstinner deleted the move_gcstate branch November 20, 2019 11:25
@vstinner vstinner mentioned this pull request Nov 20, 2019
Closed
pablogsal added a commit to pablogsal/cpython that referenced this pull request Dec 3, 2019
@pablogsal
Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (pyt…
a264ea8 
…honGH-17287)"

This reverts commit 7247407.
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner
bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (pythonGH-17287
e51cd6e 
)

* Rename _PyGC_InitializeRuntime() to _PyGC_InitState()
* finalize_interp_clear() now also calls _PyGC_Fini() in
  subinterpreters (clear the GC state).
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (pythonGH-17287
646bd0c 
)

* Rename _PyGC_InitializeRuntime() to _PyGC_InitState()
* finalize_interp_clear() now also calls _PyGC_Fini() in
  subinterpreters (clear the GC state).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot