Skip to content

gh-133273: Keep instruction definitions in bytecodes.c and optimizer_bytecodes.c in sync #133320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

gh-133273: Keep instruction definitions in bytecodes.c and optimizer_bytecodes.c in sync #133320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a09150
Keep instruction definitions in bytecodes.c and optimizer_bytecodes.c…
tomasr8 May 2, 2025
8e5e19b
Also validate sizes
tomasr8 May 3, 2025
ffe5919
Merge remote-tracking branch 'upstream/main' into validate-uops
tomasr8 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
183 changes: 183 additions & 0 deletions Lib/test/test_generated_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2069,6 +2069,189 @@ def test_missing_override_failure(self):
with self.assertRaisesRegex(AssertionError, "All abstract uops"):
self.run_cases_test(input, input2, output)

def test_validate_uop_input_length_mismatch(self):
input = """
op(OP, (arg1 -- out)) {
SPAM();
}
"""
input2 = """
op(OP, (arg1, arg2 -- out)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Must have the same number of inputs"):
self.run_cases_test(input, input2, output)

def test_validate_uop_output_length_mismatch(self):
input = """
op(OP, (arg1 -- out)) {
SPAM();
}
"""
input2 = """
op(OP, (arg1 -- out1, out2)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Must have the same number of outputs"):
self.run_cases_test(input, input2, output)

def test_validate_uop_input_name_mismatch(self):
input = """
op(OP, (foo -- out)) {
SPAM();
}
"""
input2 = """
op(OP, (bar -- out)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Inputs must have equal names"):
self.run_cases_test(input, input2, output)

def test_validate_uop_output_name_mismatch(self):
input = """
op(OP, (arg1 -- foo)) {
SPAM();
}
"""
input2 = """
op(OP, (arg1 -- bar)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Outputs must have equal names"):
self.run_cases_test(input, input2, output)

def test_validate_uop_unused_input(self):
input = """
op(OP, (unused -- )) {
}
"""
input2 = """
op(OP, (foo -- )) {
}
"""
output = """
case OP: {
stack_pointer += -1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

input = """
op(OP, (foo -- )) {
}
"""
input2 = """
op(OP, (unused -- )) {
}
"""
output = """
case OP: {
stack_pointer += -1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

def test_validate_uop_unused_output(self):
input = """
op(OP, ( -- unused)) {
}
"""
input2 = """
op(OP, ( -- foo)) {
foo = NULL;
}
"""
output = """
case OP: {
JitOptSymbol *foo;
foo = NULL;
stack_pointer[0] = foo;
stack_pointer += 1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

input = """
op(OP, ( -- foo)) {
foo = NULL;
}
"""
input2 = """
op(OP, ( -- unused)) {
}
"""
output = """
case OP: {
stack_pointer += 1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

def test_validate_uop_input_size_mismatch(self):
input = """
op(OP, (arg1[2] -- )) {
}
"""
input2 = """
op(OP, (arg1[4] -- )) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Inputs must have equal sizes"):
self.run_cases_test(input, input2, output)

def test_validate_uop_output_size_mismatch(self):
input = """
op(OP, ( -- out[2])) {
}
"""
input2 = """
op(OP, ( -- out[4])) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Outputs must have equal sizes"):
self.run_cases_test(input, input2, output)

def test_validate_uop_unused_size_mismatch(self):
input = """
op(OP, (foo[2] -- )) {
}
"""
input2 = """
op(OP, (unused[4] -- )) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Inputs must have equal sizes"):
self.run_cases_test(input, input2, output)

if __name__ == "__main__":
unittest.main()
Loading
Loading