Skip to content

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 8, 2024

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -1670,21 +1669,6 @@ def __ror__(self, left):
return Union[left, self]


class _DeprecatedGenericAlias(_SpecialGenericAlias, _root=True):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need this again in the future. But I guess it's pretty easy to add it back if/when that happens

@AlexWaygood AlexWaygood merged commit 2f4db5a into python:main May 8, 2024
@cdce8p
Copy link
Contributor

cdce8p commented May 26, 2025

Left a longer comment on the issue but to summarize I was a bit surprised to discover that just importing typing.ByteString didn't seem to create a DeprecationWarning in 3.13.

#118803 (comment)

AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Sep 16, 2025
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Sep 16, 2025
AlexWaygood added a commit that referenced this pull request Sep 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2025
…ctions.abc` (pythonGH-118804)" (pythonGH-138990)

(cherry picked from commit 530ddd3)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x (tier-3) has failed when building commit 530ddd3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/567/builds/10135) and take a look at the build logs.
  4. Check if the failure is related to this commit (530ddd3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/567/builds/10135

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.BufferedWriter>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
k

hugovk pushed a commit that referenced this pull request Sep 17, 2025
…ections.abc` (GH-118804)" (GH-138990) (#138995)

Revert "gh-118803: Remove `ByteString` from `typing` and `collections.abc` (GH-118804)" (GH-138990)
(cherry picked from commit 530ddd3)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants