Skip to content

Conversation

serhiy-storchaka
Copy link
Member

  1. _PySys_GetObject() can return NULL without setting an error.
  2. Error in PyDict_SetItemString() was not handled.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link
Member

Thanks for catching this and for the fix!

@serhiy-storchaka serhiy-storchaka merged commit c829975 into python:main Sep 18, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the _PySys_UpdateConfig-errors branch September 18, 2023 17:10
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2023

GH-109550 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2023

GH-109551 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 18, 2023
serhiy-storchaka added a commit that referenced this pull request Sep 18, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
Fix error handling in _PySys_UpdateConfig() (GH-109524)
(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants