-
Notifications
You must be signed in to change notification settings - Fork 2.4k
test: fix test due to changes in poetry-core #9992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates the tests to accommodate changes introduced in poetry-core. Specifically, it adds the "format" field to includes and packages in the test data. Class diagram showing updated test data structureclassDiagram
class TestData {
+includes
+packages
}
class Include {
+format: str
+other_fields
}
class Package {
+format: str
+other_fields
}
TestData --> Include: contains
TestData --> Package: contains
note for Include "New format field added"
note for Package "New format field added"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
233cf7b
to
53b8c9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @finswimmer - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Related to poetry-core#805
53b8c9e
to
9ef0cc1
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Related to python-poetry/poetry-core#805
Pull Request Check List
Resolves: #issue-number-here
Summary by Sourcery
Tests:
Summary by Sourcery
Tests: