Skip to content

test: fix test due to changes in poetry-core #9992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Jan 8, 2025

Related to python-poetry/poetry-core#805

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Tests:

  • Update tests to accommodate the format field added to includes and packages.

Summary by Sourcery

Tests:

  • Updated tests to handle the new "format" field in package includes and packages.

Copy link

sourcery-ai bot commented Jan 8, 2025

Reviewer's Guide by Sourcery

This PR updates the tests to accommodate changes introduced in poetry-core. Specifically, it adds the "format" field to includes and packages in the test data.

Class diagram showing updated test data structure

classDiagram
    class TestData {
        +includes
        +packages
    }
    class Include {
        +format: str
        +other_fields
    }
    class Package {
        +format: str
        +other_fields
    }
    TestData --> Include: contains
    TestData --> Package: contains
    note for Include "New format field added"
    note for Package "New format field added"
Loading

File-Level Changes

Change Details Files
Update tests to include the format field
  • Added "format" field to packages and includes in test_create_poetry_with_packages_and_includes test case
tests/test_factory.py
Update poetry-core dependency
  • Updated poetry-core dependency to use the main branch from GitHub
pyproject.toml
poetry.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@abn abn force-pushed the tests/fix-format-defaults branch 2 times, most recently from 233cf7b to 53b8c9e Compare January 9, 2025 16:17
@abn abn marked this pull request as ready for review January 9, 2025 16:18
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @finswimmer - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@abn abn enabled auto-merge (rebase) January 9, 2025 16:18
@radoering radoering force-pushed the tests/fix-format-defaults branch from 53b8c9e to 9ef0cc1 Compare January 9, 2025 16:56
@abn abn merged commit 0e4f0e7 into python-poetry:main Jan 9, 2025
73 checks passed
Copy link

github-actions bot commented Feb 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants