-
Notifications
You must be signed in to change notification settings - Fork 2.4k
improve pyproject.toml validation error messages by replacing data
with tool.poetry
#10471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
radoering
merged 2 commits into
python-poetry:main
from
Aearsears:feat/error-message-tool-poetry-section
Jul 27, 2025
Merged
improve pyproject.toml validation error messages by replacing data
with tool.poetry
#10471
radoering
merged 2 commits into
python-poetry:main
from
Aearsears:feat/error-message-tool-poetry-section
Jul 27, 2025
+15
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR updates the validation logic to prefix error paths with 'tool.poetry.' instead of 'data.' and adjusts existing tests to expect the new message format. Class diagram for updated validation error message handlingclassDiagram
class Factory {
+validate(toml_data, strict)
}
Factory : validate() now replaces 'data.' with 'tool.poetry.' in error messages
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Aearsears - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
data
with tool.poetry
radoering
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #9900
Replaces the
data
prefix in the validation error messages withtool.poetry
to better report toml structure errorsSummary by Sourcery
Replace 'data.' prefix in pyproject.toml validation error messages with 'tool.poetry.' and adjust tests accordingly
Enhancements:
Tests:
Summary by Sourcery
Replace the "data." prefix in pyproject.toml validation error messages with "tool.poetry." and adjust tests accordingly
Enhancements:
Tests: