-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore: update dependencies (especially poetry-core) ... #10374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThe File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radoering - I've reviewed your changes - here's some feedback:
- Consider adding a brief description, perhaps linking to the poetry-core changelog or explaining the reason for the update.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…nd for importlib-metadata, which is only required for Python 3.9
b254bcf
to
78779f7
Compare
Hi @radoering |
@somyarj1637 Just take a look at the changes. There is a comment:
Further, it is only Python 3.9 because we do not need |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
... and set upper bound for importlib-metadata, which is only required for Python 3.9
Summary by Sourcery
Chores: