-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix get_supported_tags
in cases where the target env has a different platform
#10361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request fixes a regression where wheels for the wrong platform could be installed when the target environment's reported platform ( No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radoering - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
e07aeb9
to
6e648c6
Compare
6e648c6
to
97367d8
Compare
97367d8
to
5c50e70
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
#9304 introduced a regression where wheels for the wrong platform were installed in rare cases. This includes:
This fix basically falls back to determine the platform tags inside the target venv if
sysconfig.get_platform()
of the target venv is different from the value from Poetry's own venv.Summary by Sourcery
Ensure correct platform tags are detected for target environments with different platforms or architectures than the host.
Bug Fixes:
sysconfig.get_platform()
value in its markers for comparison.Tests: