fix(solver): do not choose a (locked) package from an explicit source for a dependency that does not allow an explicit source

[radoering]

Pull Request Check List

Resolves: #10315

• Added tests for changed code.
• Updated documentation for changed code.

Summary by Sourcery

Improve package source selection logic in the solver to handle complex dependency scenarios with explicit sources

Bug Fixes:

• Prevent choosing a package from an explicit source when the dependency does not explicitly allow it

Tests:

• Add a comprehensive test case to verify package source selection behavior with multiple constraints and locked packages

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue in the solver where it could incorrectly choose a locked package from an explicit source for a dependency that does not allow an explicit source. A test case has been added to verify the fix.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added a test case to verify that the solver correctly handles scenarios where a dependency has multiple constraints, one of which requires an explicit source while another does not.	Added a new test case test_multiple_constraints_incomplete_explicit_source_transitive_locked to tests/puzzle/test_solver.py. The test case covers both locked and unlocked scenarios. The test case sets up a scenario where the root package depends on lib with different constraints based on the platform, and other which in turn depends on lib. The test verifies that the solver chooses the correct version of lib from the appropriate source based on the constraints and priorities.	tests/puzzle/test_solver.py
Modified the get_locked method in Provider to prevent the solver from incorrectly choosing a locked package from an explicit source when the dependency does not allow an explicit source.	Added a check to ensure that if a dependency does not have a specified source name, and a locked package is from an explicit source, the package is skipped. This prevents the solver from picking a package from an explicit source for a dependency that should be resolved from the default source.	src/poetry/puzzle/provider.py

Possibly linked issues

• Re-locking fails with transitive dependency from alternative source #10315: The PR fixes the issue by ensuring that the correct source is chosen for locked dependencies.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

• The new test case is quite complex; consider adding some comments to explain the different scenarios being tested.
• The code change looks good, but it might be worth adding a comment explaining why the continue statement is necessary.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.