-
Notifications
You must be signed in to change notification settings - Fork 2.4k
tests: make tests forwards compatible with poetry-core#851 #10274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: make tests forwards compatible with poetry-core#851 #10274
Conversation
Reviewer's Guide by SourceryThis pull request updates tests to be forward compatible with changes in poetry-core regarding the simplification of python version markers. The modified markers are equivalent. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radoering - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be worth adding a comment explaining why
poetry-core
is being installed from git. - Consider using
pytest.mark.parametrize
to avoid duplicating the expected values.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
83b08c8
to
ca920dd
Compare
ca920dd
to
c55c0c8
Compare
4105bf4
to
16d0740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radoering - I've reviewed your changes - here's some feedback:
Overall Comments:
- This is a good approach to handle the changes in
poetry-core
without breaking existing tests.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Make tests forwards compatible with python-poetry/poetry-core#851
The modified markers are equivalent.
Summary by Sourcery
Tests: