-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(env): use csh activation script for tcsh #10243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request modifies the activate command to use the csh activation script for tcsh shells, which were previously incorrectly using the bash script. A test case has been added to verify the correct behavior. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedranmiletic - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why
tcsh
is being added to thecsh
case.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: virtualenv activation currently uses Bash script when shell is tcsh, which doesn't work, so this change makes it use the csh activation script
Summary by Sourcery
Bug Fixes: