-
Notifications
You must be signed in to change notification settings - Fork 261
fix created_nested_marker
for python wildcard constraints
#853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix created_nested_marker
for python wildcard constraints
#853
Conversation
Reviewer's Guide by SourceryThis pull request fixes an issue where wildcard constraints were not correctly handled when generating environment markers. The Sequence diagram for create_nested_marker functionsequenceDiagram
participant Utils
participant Version
Utils->>Version: version.stable
Version-->>Utils: Returns stable version
Utils->>Utils: Creates environment marker with stable version
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radoering - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be clearer to use
version.base_version
instead ofversion.stable
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
b9e36e5
to
c4c4591
Compare
c4c4591
to
31be139
Compare
Resolves: python-poetry/poetry#10290
Summary by Sourcery
Bug Fixes: