Skip to content

fix missing last-modified on all platforms (#275) #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix missing last-modified on all platforms (#275) #276

wants to merge 2 commits into from

Conversation

balihb
Copy link

@balihb balihb commented Jun 13, 2023

kurtmckee
kurtmckee suggested changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To meet the "returns a float" contract and pass mypy, I think this will need to return 0.0.

@sirosen
Copy link
Member

sirosen commented Jun 13, 2023

I'm going to close this as I think #277 is a preferable path forward.

That said, I greatly appreciate the work that went into this and I hope that you continue to use check-jsonschema, and that you feel empowered to help with bug reports and fixes for any future issues you run into!

@sirosen sirosen closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kurtmckee kurtmckee kurtmckee requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balihb @sirosen @kurtmckee