Address unused variable warning on GIL-enabled builds #202
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
Sep 11, 2025
This integer variable is only used when the GIL is disabled in the build i.e. for free-threaded builds. Otherwise it will cause the compiler to emit an unused variable warning.
alexmalyshev
force-pushed
the
fix-unused
branch
from
8546968 to
8ab0ecf
Compare
Contributor
|
This particular feature of C99 is mandated by CPython since 3.6, so we're
pretty safe in using it nowadays.
|
Contributor
|
Thanks @alexmalyshev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integer variable is only used when the GIL is disabled in the build i.e. for free-threaded builds. Otherwise the compiler will emit a warning that this variable is unused.