Skip to content

Conversation

@Bluefissure
Copy link
Contributor

Update pyproject.toml to change the license field compatible with PEP 621

I'm not sure which is the best way to resolve this as the license is deprecated in a following PEP 639 (which introduces License-Expression), but making this change will at least making new pip version (> 23.0.1) not complaining.

Update pyproject.toml to change the `license` field compatible with [PEP 621](https://peps.python.org/pep-0621/#license)
Copy link
Contributor

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI completion. This is the same form of the pyproject.toml in scipy.

@EpicWink
Copy link

EpicWink commented Sep 11, 2025

See my comment:

license being a (inline) table is deprecated, and should be a string (identifying the license). See:

Try using Setuptools v77.0.3 or later. If your version of Python can't support that, try constraining cffi to below v2

The real fix here is to have cffi require setuptools >= 77.0.3 in its pyproject.toml

@mattip mattip merged commit bb50a2b into python-cffi:main Sep 11, 2025
32 checks passed
@Bluefissure Bluefissure deleted the patch-1 branch September 11, 2025 15:57
@adamjstewart
Copy link

I don't understand. We had a pyproject.toml that satisfied PEP 639. Then this PR undid this to return to a deprecated specification?

@Bluefissure
Copy link
Contributor Author

I don't understand. We had a pyproject.toml that satisfied PEP 639. Then this PR undid this to return to a deprecated specification?

Yes, I think the required setuptools >= 66.1 does not support PEP 639, we need to update that if we want to change it to PEP 639.

Oh just saw your PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants