Parallel node setup #1229
Closed
Parallel node setup #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@nicoddemus I know you reviewed my last PR. There are a fair amount of tests that assert workers pick up tests in a specific order. Is rewriting the tests to not care about order the correct fix, or should we order the nodes to pick up tests deterministically again? Are you interested in these optimization PRs at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running pytest with a high number of workers
pytest -n32, I noticed a significant amount of time is just spent on initializing the nodes (2s here), since each call toself.group.makegateway(spec)takes ~0.05s. When using a pool, the total time is instead roughly the time it takes to create one Python instance (0.05s).pytest-xdist/src/xdist/workermanage.py
Line 106 in 239def9