-
Notifications
You must be signed in to change notification settings - Fork 68
DOC: Add missing text to enclosed_tessellation #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
+ Coverage 97.4% 98.3% +0.9%
=======================================
Files 26 26
Lines 4328 4195 -133
=======================================
- Hits 4214 4123 -91
+ Misses 114 72 -42
🚀 New features to boost your workflow:
|
momepy/elements.py
Outdated
| and suboptimal resulting geometry (when the value is too large). The default | ||
| is empirically derived for the use case on | ||
| is empirically derived for the use case on building footprints represented in | ||
| meters. By default 0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily. Could be feet or something. It is represented in units of the CRS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I was copying from the docstring on line 80, which was essentially the same. I can update both to map units.
jGaboardi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks of this @jontwo !
|
I've tried to respond to both comments above. I feel the docstring to both |
|
@jontwo -- I think these edits are nice. Thank you for your attention to this. Let's put |
No problem, happy to help. This library has been super helpful for us. |
Continuing #718, this PR adds in some missing text to the docstring.