Skip to content

Conversation

@jontwo
Copy link
Contributor

@jontwo jontwo commented Nov 7, 2025

Continuing #718, this PR adds in some missing text to the docstring.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.3%. Comparing base (4037c70) to head (299e9d4).
⚠️ Report is 127 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #722     +/-   ##
=======================================
+ Coverage   97.4%   98.3%   +0.9%     
=======================================
  Files         26      26             
  Lines       4328    4195    -133     
=======================================
- Hits        4214    4123     -91     
+ Misses       114      72     -42     
Files with missing lines Coverage Δ
momepy/elements.py 97.9% <ø> (+1.0%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

and suboptimal resulting geometry (when the value is too large). The default
is empirically derived for the use case on
is empirically derived for the use case on building footprints represented in
meters. By default 0.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily. Could be feet or something. It is represented in units of the CRS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I was copying from the docstring on line 80, which was essentially the same. I can update both to map units.

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks of this @jontwo !

@jontwo
Copy link
Contributor Author

jontwo commented Nov 10, 2025

I've tried to respond to both comments above. I feel the docstring to both morphological_tessellation and enclosed_tessellation should be the same as it appears to be the same parameter. If I'm wrong, I'm happy to change it and remove the "represented in map units".

@jontwo jontwo requested a review from jGaboardi November 12, 2025 09:32
@jGaboardi
Copy link
Member

@jontwo -- I think these edits are nice. Thank you for your attention to this. Let's put By default 0.5 directly after map units. on the same line with no break.

@jontwo
Copy link
Contributor Author

jontwo commented Nov 12, 2025

@jontwo -- I think these edits are nice. Thank you for your attention to this. Let's put By default 0.5 directly after map units. on the same line with no break.

No problem, happy to help. This library has been super helpful for us.

@martinfleis martinfleis merged commit 8af0b2e into pysal:main Nov 12, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants