integrity: refine Accept header handling #17498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pypi#17084. Signed-off-by: William Woodruff <[email protected]>
SpecLad
reviewed
Jan 24, 2025
Signed-off-by: William Woodruff <[email protected]>
di
reviewed
Jan 27, 2025
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
di
approved these changes
Jan 27, 2025
|
trail-of-forks:ww/integrity-better-accept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the
Accepthandling for this endpoint in the following ways:'identity'marker to ensure an adequate fallback when the user doesn't explicitly specifyAcceptapplication/json, although this could be removed from the changeset(NB: The main reason I added
application/jsonis to ensure fallbacks/q-factor sorting works as expected.)I've also added a bunch of parametrized tests to ensure that we handle various combinations/orders/q-values correctly.
See #17084.