feat: Abstract out caching in discovery #2946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have refactored the code to abstract out caching through an interface. This change lays the groundwork for extracting discovery into its own package. Here’s a summary of what I did: - I introduced a new `Cache` interface in `src/virtualenv/discovery/cache.py`. - I created a file-based implementation of this interface, `FileCache`, in `src/virtualenv/discovery/file_cache.py`. - I refactored the existing `cached_py_info.py` to use the `Cache` interface, decoupling it from the file-based implementation. - I updated `py_info.py` to work with the refactored `cached_py_info`. Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Emre Şafak <[email protected]>
gaborbernat
requested changes
Aug 7, 2025
* Add a docstring to the Cache ABC explaining the purpose of close() and __exit__ methods. * Remove unused import from cached_py_info.py. Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Emre Şafak <[email protected]>
gaborbernat
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the code to abstract out caching through an interface. This change lays the groundwork for extracting discovery into its own package (#2074).
Here’s a summary of what I did:
Cacheinterface insrc/virtualenv/discovery/cache.py.FileCache, insrc/virtualenv/discovery/file_cache.py.cached_py_info.pyto use theCacheinterface, decoupling it from the file-based implementation.py_info.pyto work with the refactoredcached_py_info.tox -e fix)docs/changelogfolder