Revert _log_skipped_link() optimization to restore requires-python information in skipped links errors
#13333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of if not logger.isEnabledFor(logging.DEBUG) in _log_skipped_link() means that skipped links are not stored, preventing requires_python_skipped_reasons() from ever returning anything.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of if not logger.isEnabledFor(logging.DEBUG) in _log_skipped_link() means that skipped links are not stored, preventing requires_python_skipped_reasons() from ever returning anything.
Partial revert of #13128.
Towards #13260, although I'm not going to close that until I write a test. In the interim, I'll simply revert this part of my old PR because it was only intended as an optimization.