Skip to content

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Sep 13, 2025

Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz enabled auto-merge September 15, 2025 15:55
@webknjaz
Copy link
Member

Looks like we need another ignore for https://developer.hashicorp.com/vagrant in conf.py (in a separate PR).

@ncoghlan
Copy link
Member

#1912 removes the Vagrant link that is causing CI problems.

@webknjaz
Copy link
Member

@ncoghlan that Update branch button usually has a drop-down. Whenever possible, choose the rebase option. Merge queues will already create merge commits, we shouldn't double their number if that can be avoided.

@webknjaz
Copy link
Member

linkcheck crashes on 3 new broken links.

@ncoghlan
Copy link
Member

For example, the link to https://packaging.python.org/en/latest/specifications/schemas/build-details-v1.0.schema.json in https://python-packaging-user-guide--1910.org.readthedocs.build/en/1910/specifications/build-details/v1.0/#build-details-v1-0 fails to resolve .

That's going to be a recurring bootstrapping problem: if the schema metadata links to their own canonical location from the $id field, the build that adds any given schema is going to fail (since it won't be present on the live site yet).

Can we instruct the link checker to resolve absolute https://packaging.python.org/en/latest/* links relative to the docs build anchor URL? (we don't want to make the $id fields themselves relative)

auto-merge was automatically disabled September 18, 2025 16:21

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants