Skip to content

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Sep 10, 2025

@brettcannon
Copy link
Member Author

Copy link
Contributor

@befeleme befeleme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the clarification agreed upon.

you want to allow users a choice of multiple licenses). You can use
parenthesis (``()``) for grouping to form expressions that cover even the most
complex situations.
In short, ``License-1 AND License-2`` mean that *both* licenses apply, or parts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"or parts of it" no longer makes sense here after you removed "your project".

Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct after reviewing the glossary with definitions, but I'm not 100% sure. "Distribution Archive" refers to "Distribution Package" which doesn't mention sdist or wheel but seems to only cover the former. Wheels (and previously eggs) seem to be "Built Distribution"'s and not "Distribution Archive"'s.

If that sounds right, then this PR LGTM.

@pfmoore
Copy link
Member

pfmoore commented Sep 12, 2025

TBH, the terminology is a bit of a mess, and no-one uses most of it in real life. The key term in my view is "Distribution Package", and that's commonly used to mean either a wheel or a sdist1. Personally I use "Distribution File" when I want to be 100% clear I'm talking about a physical file on disk (and I'm surprised to see that "Distribution Archive" is the official term for that, and somewhat disappointed as I think it's less clear - one of the ways it's less clear is that the term "archive" doesn't feel like it applies to wheels, whereas the term "file" obviously does).

The key point for me is that the revised wording is clear in its intent, and I think it is. We can consider replacing the term "Distribution Archive" with "Distribution File" (globally, not just here) as a separate exercise, if anyone thinks it's important enough to spend time on.

Footnotes

  1. I suspect the wording is a bit vague because it was written in the days when other binary distribution formats, like bdist_wininst or bdist_rpm, still existed...

@rgommers
Copy link
Contributor

Thanks for the context @pfmoore, that helped. I re-read the files being changed in full, and I think this PR is fine indeed - it achieve the "distribution license not project's contributing license" well enough, and this PR is unrelated to auditwheel effects (that's the other PR @brettcannon opened). So 👍🏼 from me on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants