Implement Numba VM #1604
Draft
Implement Numba VM #1604
+733
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jorenham
reviewed
Sep 5, 2025
| kwargs.setdefault("cache", config.numba__cache) | ||
| kwargs.setdefault("no_cpython_wrapper", True) | ||
| kwargs.setdefault("no_cfunc_wrapper", True) | ||
| kwargs.setdefault("cache", True) |
There was a problem hiding this comment.
Note that the numba currently can't detect changes in other modules, which could lead to outdated caches. I'm guessing that's why they've decided to make it opt-in
Comment on lines
+19
to
+23
| else: | ||
| from pytensor.link.numba.dispatch.basic import numba_njit | ||
|
|
||
| jitted_fn = numba_njit(fn, no_cpython_wrapper=False, no_cfunc_wrapper=False) | ||
| return jitted_fn | ||
| jitted_fn = numba_njit(fn, no_cpython_wrapper=False, no_cfunc_wrapper=False) | ||
| return jitted_fn |
There was a problem hiding this comment.
I suppose there's no need for this else branch 🤷🏻
Comment on lines
+594
to
+595
| with open(filename, "wb") as f: | ||
| f.write(src.encode()) |
There was a problem hiding this comment.
Suggested change
| with open(filename, "wb") as f: | |
| f.write(src.encode()) | |
| filename.write_bytes(src.encode()) |
| @@ -598,6 +609,9 @@ def compile_function_src( | |||
|
|
|||
| res = cast(Callable, local_env[function_name]) | |||
| res.__source__ = src # type: ignore | |||
|
|
|||
| global COMPILED_SRC_FUNCTIONS | |||
There was a problem hiding this comment.
I don't think this needs a global
Suggested change
| global COMPILED_SRC_FUNCTIONS |
I don't, but it's still too early for that sort of feedback. I'm just thinkering around at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1604.org.readthedocs.build/en/1604/