Add test to compare draws when var_names is used in pm.sample()
#7287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can remove the previous test (the one above), since this covers everything that is tested there. You can reuse the old name that's also shorter |
ricardoV94
approved these changes
Apr 28, 2024
ricardoV94
added
tests
no releasenotes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7287 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 102 102
Lines 17018 17018
=======================================
Hits 15713 15713
Misses 1305 1305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test that complements the bug fix in #7284
It finally closes #7258
📚 Documentation preview 📚: https://pymc--7287.org.readthedocs.build/en/7287/