Skip to content

Do not use seeded_test fixture in exported BaseTestDistributionRandom #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Do not use seeded_test fixture in exported BaseTestDistributionRandom #6848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymc/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ class BaseTestDistributionRandom:
repeated_params_shape = 5
random_state = None

def test_distribution(self, seeded_test):
def test_distribution(self):
self.validate_tests_list()
if self.pymc_dist == pm.Wishart:
with pytest.warns(UserWarning, match="can currently not be used for MCMC sampling"):
Expand Down
2 changes: 1 addition & 1 deletion tests/distributions/test_continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1825,7 +1825,7 @@ class TestStudentT(BaseTestDistributionRandom):

class TestHalfStudentT(BaseTestDistributionRandom):
def halfstudentt_rng_fn(self, df, loc, scale, size, rng):
return np.abs(st.t.rvs(df=df, loc=loc, scale=scale, size=size))
return np.abs(st.t.rvs(df=df, loc=loc, scale=scale, size=size, random_state=rng))

pymc_dist = pm.HalfStudentT
pymc_dist_params = {"nu": 5.0, "sigma": 2.0}
Expand Down
2 changes: 1 addition & 1 deletion tests/distributions/test_multivariate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1972,7 +1972,7 @@ class TestKroneckerNormal(BaseTestDistributionRandom):
def kronecker_rng_fn(self, size, mu, covs=None, sigma=None, rng=None):
cov = pm.math.kronecker(covs[0], covs[1]).eval()
cov += sigma**2 * np.identity(cov.shape[0])
return st.multivariate_normal.rvs(mean=mu, cov=cov, size=size)
return st.multivariate_normal.rvs(mean=mu, cov=cov, size=size, random_state=rng)

pymc_dist = pm.KroneckerNormal

Expand Down