Skip to content

Fix check_all_tests_are_covered hook #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix check_all_tests_are_covered hook #6756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ repos:
- id: check-no-tests-are-ignored
additional_dependencies: [pandas,pyyaml]
entry: python scripts/check_all_tests_are_covered.py
files: ^\.github/workflows/pytest\.yml$
files: ^.github/workflows/tests.yml$
language: python
name: Check no tests are ignored
pass_filenames: false
Expand Down
6 changes: 4 additions & 2 deletions scripts/check_all_tests_are_covered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,11 @@ def from_yaml():
_log.info("Number of test runs (❌=0, ✅=once)\n%s", df.replace(0, "❌").replace(1, "✅"))

if ignored_by_all:
_log.warning("%i tests are completely ignored:\n%s", len(ignored_by_all), ignored_by_all)
raise AssertionError(
f"{len(ignored_by_all)} tests are completely ignored:\n{ignored_by_all}"
)
if run_multiple_times:
raise Exception(
raise AssertionError(
f"{len(run_multiple_times)} tests are run multiple times with the same OS and floatX setting:\n{run_multiple_times}"
)
return
Expand Down