Skip to content

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Mar 23, 2023

Update the dev container base image, and also run the initial Conda installs and pre-commit installs in the background.

What is this PR about?
...

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • Minor improvements to improve the GitPod experience

@maresb
Copy link
Contributor Author

maresb commented Mar 24, 2023

Hmm, any idea why the tests are blocked?

@reshamas
Copy link
Member

@Armavica may have an idea?

@Armavica
Copy link
Member

Armavica commented Mar 25, 2023

I would say that it is because none of the files modified match any of the patterns listed here:

https://github.com/pymc-devs/pymc/blob/main/.github/workflows/tests.yml#L4-L12

@maresb
Copy link
Contributor Author

maresb commented Mar 25, 2023

Ah, so we should adjust to make the tests conditionally required (if possible) or ensure required tests run regardless. For now, is there any admin who could override?

@ricardoV94
Copy link
Member

Ah, so we should adjust to make the tests conditionally required (if possible) or ensure required tests run regardless. For now, is there any admin who could override?

You mean to merge?

@maresb
Copy link
Contributor Author

maresb commented Mar 25, 2023

You mean to merge?

Yes

@ricardoV94 ricardoV94 merged commit 83cd926 into pymc-devs:main Mar 25, 2023
@maresb
Copy link
Contributor Author

maresb commented Mar 25, 2023

Thanks @ricardoV94!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants