Skip to content

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Nov 20, 2022

The goals here are:

  1. to fix an error in the a notebook (Update Prior and Posterior Predictive Checks tutorial #6322) and
  2. make sure that this doesn't happen again (Errors in core notebooks should fail doc build #6323).

The first commit should achieve & confirm goal 2., and subsequent commits will be added to fix notebooks.

Checklist

Major / Breaking Changes

  • None

Bugfixes / New features

  • None

Docs / Maintenance

  • Make sure that notebook errors fail the docs build
  • Fix notebook errors

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems to be working. I would also add nb_execution_allow_errors=False to shield ourselves from potential default changes

@ricardoV94 ricardoV94 added this to the v5.0.0 milestone Dec 6, 2022
@michaelosthege michaelosthege self-assigned this Dec 6, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril
Copy link
Member

Let's try nb_execution_timeout = 60 and see if it is enough time, otherwise reduce chains and/or draws in the longest running cells.

@michaelosthege michaelosthege marked this pull request as ready for review December 6, 2022 21:58
@michaelosthege michaelosthege merged commit 102fdc9 into pymc-devs:main Dec 6, 2022
@michaelosthege michaelosthege deleted the issues-6322-6323 branch December 6, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants