Seed pm.sample in BaseSampler(SeededTest) to make deriving test classes deterministic #6251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Add a seed to
pm.sample()
inBaseSampler
, which is aSeededTest
but its draws are not yet seeded.This solves flaky tests like the one reported in #6246. Closes #6246
Given the complex structure of the tests in this file, made of many mixins of fixtures, each with its own class hierarchies, I found
BaseSampler
to be the only point where the seed can be added meaningfully.Checklist
Docs / Maintenance