Skip to content

Fix flaky TestTruncation.truncation_discrete_random #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Fix flaky TestTruncation.truncation_discrete_random #6229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05d99c
Fix Potential flaky test: truncation_discrete_random
mattiadg Oct 18, 2022
f97df7c
Update pymc/tests/distributions/test_truncated.py
mattiadg Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pymc/tests/distributions/test_truncated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,10 @@ def test_truncation_discrete_random(op_type, lower, upper):
assert np.any(xt_draws == upper)
else:
with pytest.raises(TruncationError, match="^Truncation did not converge"):
draw(xt)
# Rejections sampling with probability = (1 - p ** max_n_steps) ** sample_size =
# = (1 - 0.2 ** 3) ** 500 = 0.018
# Still, this probability can be too high to make this test pass with any seed.
draw(xt, random_seed=2297228)


@pytest.mark.parametrize("lower, upper", [(2, np.inf), (2, 5), (-np.inf, 5)])
Expand Down