Fix bug in get_vars_in_point_list when model does not have variables that exist in the trace
#6203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model and in the point list
ricardoV94
changed the title
get_vars_in_point_list only checks vars that are both in the model and the point listget_vars_in_point_list when model does not have variables that are in the trace
ricardoV94
changed the title
get_vars_in_point_list when model does not have variables that are in the traceget_vars_in_point_list when model does not have variables that exist in the trace
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6203 +/- ##
=======================================
Coverage 93.58% 93.59%
=======================================
Files 101 101
Lines 22151 22153 +2
=======================================
+ Hits 20731 20733 +2
Misses 1420 1420
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6199
What is this PR about?
...
Checklist
Major / Breaking Changes
Bugfixes / New features
get_vars_in_point_listwas implemented in a way that expected all of the variables that were contained in the trace, to also be defined in the model. This fixes that problem and makes the function return a list of the variables that are defined both in the trace and in the model.Docs / Maintenance