Skip to content

Fix DiscreteUniformRV dropping degenerate dimension #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Fix DiscreteUniformRV dropping degenerate dimension #6151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pymc/distributions/discrete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

from aesara.tensor.random.basic import (
RandomVariable,
ScipyRandomVariable,
bernoulli,
betabinom,
binomial,
Expand Down Expand Up @@ -1117,15 +1118,15 @@ def logcdf(value, good, bad, n):
)


class DiscreteUniformRV(RandomVariable):
class DiscreteUniformRV(ScipyRandomVariable):
name = "discrete_uniform"
ndim_supp = 0
ndims_params = [0, 0]
dtype = "int64"
_print_name = ("DiscreteUniform", "\\operatorname{DiscreteUniform}")

@classmethod
def rng_fn(cls, rng, lower, upper, size=None):
def rng_fn_scipy(cls, rng, lower, upper, size=None):
return stats.randint.rvs(lower, upper + 1, size=size, random_state=rng)


Expand Down
4 changes: 4 additions & 0 deletions pymc/tests/distributions/test_discrete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,6 +1042,10 @@ def discrete_uniform_rng_fn(self, size, lower, upper, rng):
"check_rv_size",
]

def test_implied_degenerate_shape(self):
x = pm.DiscreteUniform.dist(0, [1])
assert x.eval().shape == (1,)


class TestDiracDelta(BaseTestDistributionRandom):
def diracdelta_rng_fn(self, size, c):
Expand Down