Remove note that probs are automatically rescaled #6066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This concerns the documentation of the Categorical and Multinomial distributions. Probabilities are indeed rescaled, but only when they are numeric, and with a warning to discourage users from that. Hence this should not be in the documentation. See issue pymc-devs#5978.
ricardoV94
approved these changes
Aug 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #6066 +/- ##
==========================================
- Coverage 89.56% 87.98% -1.59%
==========================================
Files 72 72
Lines 12941 12941
==========================================
- Hits 11591 11386 -205
- Misses 1350 1555 +205
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This concerns the documentation of the Categorical and Multinomial
distributions. Probabilities are indeed rescaled, but only when they
are numeric, and with a warning to discourage users from that.
Hence this should not be in the documentation.
See issue #5978.
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance