Skip to content

Fix docker image build #5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2022
Merged

Fix docker image build #5977

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f1f831c
:bug: indent tags
symeneses Jul 15, 2022
e421962
:heavy_minus_sign: remove checkout
symeneses Jul 18, 2022
19dd15e
:bug: use var in command
symeneses Jul 18, 2022
e70a6b3
:truck: renaming flow
symeneses Jul 18, 2022
7c0bf65
:construction: conf for testing
symeneses Jul 18, 2022
69d0aa4
:white_check_mark: trigger with PR
symeneses Jul 18, 2022
7654cde
:truck: rename env var
symeneses Jul 18, 2022
fb20061
:construction: commenting for testing
symeneses Jul 18, 2022
e7ac630
:heavy_plus_sign: add checkout
symeneses Jul 18, 2022
7972cb5
:rocket: remove testing conf
symeneses Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: push-docker-image
name: docker-image

on:
release:
Expand All @@ -18,20 +18,20 @@ jobs:
- name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
username: ${{ secrets.DOCKER_HUB_USERNAME }}
password: ${{ secrets.DOCKER_HUB_TOKEN }}

- name: Extract metadata (tags, labels) for Docker
id: meta
uses: docker/metadata-action@v4
with:
images: |
name=pymc/pymc,enable=true
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
name=pymc/pymc,enable=true
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}

- name: Build and load image
uses: docker/build-push-action@v3
Expand All @@ -43,7 +43,7 @@ jobs:

- name: Test importing pymc
run: |
docker run --rm build-test conda run -n pymc-dev python -c 'import pymc;print(pymc.__version__)'
docker run --rm ${{ env.CONTAINER_NAME }} conda run -n pymc-dev python -c 'import pymc;print(pymc.__version__)'

- name: Build and push
uses: docker/build-push-action@v3
Expand Down