Skip to content

Conversation

keesterbrugge
Copy link
Contributor

@keesterbrugge keesterbrugge commented Jul 12, 2022

What is this PR about?
Bumping aesara from 2.7.5

The reason is that pypi is able to properly extract the dependencies of aesara >=2.7.6, but not of 2.7.5, see this ticket for more info. So AFAICT with this change pymc and all it's dependencies will be properly added to our pypi-mirror by just adding pymc to it and will be installable with just pip install pymc :D

Thanks for the awesome library!

...

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • Bump aesara dependency to 2.7.7

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #5970 (0cc6e23) into main (82d7b0e) will decrease coverage by 0.00%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5970      +/-   ##
==========================================
- Coverage   89.38%   89.38%   -0.01%     
==========================================
  Files          73       73              
  Lines       13249    13251       +2     
==========================================
+ Hits        11843    11844       +1     
- Misses       1406     1407       +1     
Impacted Files Coverage Δ
pymc/data.py 80.08% <33.33%> (-1.41%) ⬇️
pymc/variational/opvi.py 87.04% <50.00%> (ø)
pymc/ode/ode.py 85.85% <100.00%> (ø)
pymc/sampling_jax.py 96.93% <0.00%> (-0.02%) ⬇️
pymc/func_utils.py 87.50% <0.00%> (ø)
pymc/distributions/discrete.py 99.21% <0.00%> (ø)
pymc/parallel_sampling.py 86.79% <0.00%> (+0.99%) ⬆️

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there were two breaking API changes not mentioned in the release notes of the patch version. (at.unbroadcast and at.patternbroadcast)

Did they originate from aesara-devs/aesara#915?
Maybe @ricardoV94 knows how to work around these API breaks?

@ricardoV94
Copy link
Member

I'm taking a look!

@ricardoV94 ricardoV94 changed the title Bump aesara from 2.7.5 to 2.7.6 Bump aesara Jul 15, 2022
@ricardoV94 ricardoV94 changed the title Bump aesara Bump aesara dependency Jul 15, 2022
@twiecki twiecki merged commit 05e39e1 into pymc-devs:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants