Skip to content

Conversation

saurbhc
Copy link
Contributor

@saurbhc saurbhc commented Jul 9, 2022

What is this PR about?
Issue #5459 - Update Docstrings for ZeroInflatedPoisson, DiracDelta and OrderedLogistic classes

Checklist

Major / Breaking Changes

  • None

Bugfixes / New features

  • None

Docs / Maintenance

#DataUmbrellaPyMCSprint
cc: @reshamas
cc: @mariyayb

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #5962 (aa3a073) into main (e7d0607) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5962      +/-   ##
==========================================
- Coverage   89.42%   89.41%   -0.01%     
==========================================
  Files          73       73              
  Lines       13292    13292              
==========================================
- Hits        11886    11885       -1     
- Misses       1406     1407       +1     
Impacted Files Coverage Δ
pymc/distributions/discrete.py 99.21% <ø> (ø)
pymc/step_methods/hmc/base_hmc.py 89.76% <0.00%> (-0.79%) ⬇️

@cluhmann
Copy link
Member

cluhmann commented Jul 9, 2022

The types and spacing look good to me. You might want to include :context: close-figs just after the .. plot:: as detailed in the tutorial.

@cluhmann
Copy link
Member

This LGTM. Just need a core dev to approve.

Copy link
Member

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloctavodia aloctavodia merged commit b94b8b6 into pymc-devs:main Jul 13, 2022
@aloctavodia
Copy link
Member

thanks @saurbhc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants