Skip to content

Conversation

moshelooks
Copy link
Contributor

@moshelooks moshelooks commented Jul 4, 2022

import pymc as pm
with pm.Model("foo"):
    print(pm.Normal("foobar"), pm.Normal("baz"))

before: foobar foo::baz
after: foo::foobar foo::baz

What is this PR about?
...

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • The model name did not show up in the first RV name

Docs / Maintenance

  • ...

```
import pymc as pm
with pm.Model("foo"):
    print(pm.Normal("foobar"), pm.Normal("baz"))
```

before: `foobar foo::baz`
after: `foo::foobar foo::baz`
@ricardoV94 ricardoV94 requested a review from ferrine July 5, 2022 04:21
@ferrine
Copy link
Member

ferrine commented Jul 5, 2022

We need a missing test for that

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #5951 (5660f00) into main (bc8e8cf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5951      +/-   ##
==========================================
- Coverage   89.54%   89.53%   -0.01%     
==========================================
  Files          73       73              
  Lines       13271    13271              
==========================================
- Hits        11883    11882       -1     
- Misses       1388     1389       +1     
Impacted Files Coverage Δ
pymc/model.py 88.20% <100.00%> (ø)
pymc/step_methods/hmc/base_hmc.py 89.76% <0.00%> (-0.79%) ⬇️

@moshelooks
Copy link
Contributor Author

We need a missing test for that

Added one.

@ferrine ferrine merged commit 58a6a02 into pymc-devs:main Jul 5, 2022
@ferrine
Copy link
Member

ferrine commented Jul 5, 2022

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants