Skip to content

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented Jun 20, 2022

Fixing rest of the mentions of not implemented functionality in VI

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #5916 (998fb6d) into main (121a5ae) will decrease coverage by 5.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5916      +/-   ##
==========================================
- Coverage   89.49%   84.38%   -5.11%     
==========================================
  Files          73       73              
  Lines       13274    13265       -9     
==========================================
- Hits        11879    11194     -685     
- Misses       1395     2071     +676     
Impacted Files Coverage Δ
pymc/variational/approximations.py 55.39% <ø> (-31.30%) ⬇️
pymc/variational/opvi.py 75.16% <ø> (-11.86%) ⬇️
pymc/variational/inference.py 51.61% <50.00%> (-34.18%) ⬇️
pymc/variational/updates.py 21.67% <0.00%> (-70.45%) ⬇️
pymc/variational/test_functions.py 38.09% <0.00%> (-61.91%) ⬇️
pymc/variational/stein.py 48.33% <0.00%> (-51.67%) ⬇️
pymc/data.py 37.95% <0.00%> (-43.68%) ⬇️
pymc/distributions/transforms.py 59.63% <0.00%> (-40.37%) ⬇️
pymc/variational/operators.py 57.14% <0.00%> (-35.72%) ⬇️
... and 12 more

:math:`{\cal Z}=\{\mathbf{z}_{i}\}_{i=1}^{N}`, where
:math:`\mathbf{z}_{i}=\{\mathbf{z}_{i}^{k}\}_{k=1}^{V_{l}}`.
These RVs are used only in AEVB.
These RVs are used only in AEVB (which is not implemented in PyMC).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to mention them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mentioned in math formulas

@twiecki twiecki merged commit c492f64 into main Jun 21, 2022
@twiecki twiecki deleted the vi-docs branch June 21, 2022 17:51
@michaelosthege michaelosthege added this to the v4.1.0 milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants